8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) #23909

prrace · 2025-03-04T23:41:36Z

Back in JDK 21 we deprecated-for-removal SynthLookAndFeel.load(URL) and targeted it to be removed under this bug ID in JDK 25 .. which is now here.

No open tests needed to be updated to accommodate this removal
I did find one closed manual test, written to explicitly test this API back when it was added, and I'll need to remove that, but it doesn't affect this PR.

There will be a CSR (and probably a release note too).

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8351238 to be approved

Issues

JDK-8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) (Bug - P4)
JDK-8351238: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) (CSR)

Reviewers

Alexander Zvegintsev (@azvegint - Reviewer)
Tejesh R (@TejeshR13 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23909/head:pull/23909
$ git checkout pull/23909

Update a local copy of the PR:
$ git checkout pull/23909
$ git pull https://git.openjdk.org/jdk.git pull/23909/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23909

View PR using the GUI difftool:
$ git pr show -t 23909

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23909.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-03-04T23:42:32Z

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-03-04T23:42:43Z

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url)

Reviewed-by: azvegint, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 105 new commits pushed to the master branch:

a7ad414: 8351327: -XX:AOTMode=record interferes with application execution
41cc049: 8350840: C2: x64 Assembler::vpcmpeqq assert: failed: XMM register should be 0-15
a347ecd: 8350905: Shenandoah: Releasing a WeakHandle's referent may extend its lifetime
5502ce7: 8351699: Problem list com/sun/jdi/JdbStopInNotificationThreadTest.java with ZGC
cdf7632: 8351444: Shenandoah: Class Unloading may encounter recycled oops
930455b: 8351640: Print reason for making method not entrant
895f64a: 8351142: Add JFR monitor deflation and statistics events
db531bf: 8351881: Tidy complains about missing "alt" attribute
02c850f: 8350982: -server|-client causes fatal exception on static JDK
2371696: 8303770: Remove Baltimore root certificate expiring in May 2025
... and 95 more: https://git.openjdk.org/jdk/compare/55987925fd8ba5d7782934194141fe425a9041be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-03-04T23:43:12Z

@prrace The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

prrace · 2025-03-04T23:45:35Z

/csr

openjdk · 2025-03-04T23:46:40Z

@prrace has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@prrace this pull request must refer to an issue in JBS to be able to link it to a CSR request. To refer this pull request to an issue in JBS, please update the title of this pull request to just the issue ID.

mlbridge · 2025-03-04T23:59:11Z

Webrevs

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java

azvegint · 2025-03-05T14:31:04Z

It is also mentioned in

jdk/src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html

Lines 57 to 58 in caaf409

    
           <a href="../../../../../javax/swing/plaf/synth/SynthLookAndFeel.html#load(java.net.URL)"> 
        
             SynthLookAndFeel.load(URL)</a> methods.

prrace · 2025-03-05T22:47:11Z

It is also mentioned in

jdk/src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html

Lines 57 to 58 in caaf409

<a href="../../../../../javax/swing/plaf/synth/SynthLookAndFeel.html#load(java.net.URL)">

SynthLookAndFeel.load(URL)</a> methods.

Ah. I'd forgotten that. I had updated it back in JDK 21 but it slipped my mind this time round.

I'll remove the relevant text.
Hmm, is that specific text part of the spec needed for the CSR ? I didn't include it in the JDK 21 case, and it seems to be just examples, so I am going to say no.

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java

prrace · 2025-03-05T23:04:43Z

It is also mentioned in

jdk/src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html

Lines 57 to 58 in caaf409

<a href="../../../../../javax/swing/plaf/synth/SynthLookAndFeel.html#load(java.net.URL)">

SynthLookAndFeel.load(URL)</a> methods.

Ah. I'd forgotten that. I had updated it back in JDK 21 but it slipped my mind this time round.

fixed

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java

mrserb · 2025-03-06T00:11:26Z

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java

@@ -34,7 +34,6 @@
 import java.io.BufferedInputStream;
 import java.io.IOException;
 import java.io.InputStream;
-import java.net.MalformedURLException;
 import java.net.URL;
 import java.net.URLClassLoader;


Is URLClassLoader no longer used?

seems so. I'll remove it.

URLCLassLoader still not removed it seems..I dont see its usage in the file..

TejeshR13

LGTM. Just have to update copyright year.

prrace · 2025-03-13T20:12:33Z

/integrate

openjdk · 2025-03-13T20:13:32Z

Going to push as commit aa047ee.
Since your change was applied there have been 124 commits pushed to the master branch:

cd1be91: 8319055: JCMD should not buffer the whole output of commands
248c373: 8351266: JFR: -XX:StartFlightRecording:report-on-exit
03ef79c: 8346470: Improve WriteBarrier JMH to have old-to-young refs
b50fe9b: 8280818: Expand bug8033699.java to iterate over all LaFs
771e160: 8351323: Parameterize compiler and linker flags for iconv
0ff1c08: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll
37ec796: 8351500: G1: NUMA migrations cause crashes in region allocation
4e51a8c: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long)
7e3bc81: 8351216: ZGC: Store NUMA node count
82eb780: 8351349: GSSUtil.createSubject has outdated access control context and policy related text
... and 114 more: https://git.openjdk.org/jdk/compare/55987925fd8ba5d7782934194141fe425a9041be...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-03-13T20:13:39Z

@prrace Pushed as commit aa047ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8319192

bd7549b

openjdk bot changed the title ~~8319192~~ 8319192: Mar 4, 2025

openjdk bot added the client [email protected] label Mar 4, 2025

openjdk bot added the csr Pull request needs approved CSR before integration label Mar 4, 2025

prrace changed the title ~~8319192:~~ 8319192 Mar 4, 2025

openjdk bot changed the title ~~8319192~~ 8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) Mar 4, 2025

openjdk bot added the rfr Pull request is ready for review label Mar 4, 2025

8319192

6656254

prsadhuk reviewed Mar 5, 2025

View reviewed changes

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java Show resolved Hide resolved

azvegint reviewed Mar 5, 2025

View reviewed changes

src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java Outdated Show resolved Hide resolved

8319192

f0b771b

azvegint approved these changes Mar 5, 2025

View reviewed changes

mrserb reviewed Mar 6, 2025

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Mar 7, 2025

TejeshR13 approved these changes Mar 13, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Mar 13, 2025

openjdk bot closed this Mar 13, 2025

openjdk bot removed the ready Pull request is ready to be integrated label Mar 13, 2025

openjdk bot removed the rfr Pull request is ready for review label Mar 13, 2025

8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) #23909

8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) #23909

Uh oh!

Conversation

prrace commented Mar 4, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issues

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 4, 2025

Uh oh!

openjdk bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Mar 4, 2025

Uh oh!

prrace commented Mar 4, 2025

Uh oh!

openjdk bot commented Mar 4, 2025

Uh oh!

mlbridge bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

azvegint commented Mar 5, 2025

Uh oh!

prrace commented Mar 5, 2025

Uh oh!

Uh oh!

prrace commented Mar 5, 2025

Uh oh!

Uh oh!

mrserb Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

prrace Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

TejeshR13 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prrace commented Mar 13, 2025

Uh oh!

openjdk bot commented Mar 13, 2025

Uh oh!

openjdk bot commented Mar 13, 2025

Uh oh!

Uh oh!

prrace commented Mar 4, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Mar 4, 2025 •

edited

Loading

mlbridge bot commented Mar 4, 2025 •

edited

Loading

TejeshR13 left a comment •

edited

Loading